Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Granular Services Counts to Telemetry #5627

Merged
merged 17 commits into from
Jun 4, 2024
Merged

Add Granular Services Counts to Telemetry #5627

merged 17 commits into from
Jun 4, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 27, 2024 •
edited
Loading

Proposed changes

This change granulaises the counting of services so instead of a total number, this adds a count for each service
eg. ClusterIP, LoadBalancer, NodePort and ExternalName.

I have added go tests for this functionality.

kubectl get services -A
NAMESPACE     NAME                                  TYPE           CLUSTER-IP       EXTERNAL-IP                                                     PORT(S)                      AGE
default       coffee-svc                            ClusterIP      10.99.38.53      <none>                                                          80/TCP                       91m
default       externalname-service                  ExternalName   <none>           secure-app-external-backend-svc.external-ns.svc.cluster.local   <none>                       45m
default       kubernetes                            ClusterIP      10.96.0.1        <none>                                                          443/TCP                      92m
default       my-release-nginx-ingress-controller   LoadBalancer   10.111.0.251     <pending>                                                       80:30572/TCP,443:31414/TCP   2m24s
default       tea-svc                               ClusterIP      10.103.202.113   <none>                                                          80/TCP                       91m
external-ns   secure-app-external-backend-svc       ClusterIP      10.111.84.145    <none>                                                          8443/TCP                     45m
kube-system   kube-dns                              ClusterIP      10.96.0.10       <none>                                                          53/UDP,53/TCP,9153/TCP       92m

Here is a snippet of the log

Secrets:1 ClusterIPServices:5 NodePortServices:0 LoadBalancerServices:1 ExternalNameServices:1

Resolves: #5452

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners May 27, 2024 15:56
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code labels May 27, 2024
jjngx
jjngx approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ADubhlaoich
ADubhlaoich approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise.

@AlexFenlon AlexFenlon enabled auto-merge (squash) May 29, 2024 11:17
@AlexFenlon AlexFenlon disabled auto-merge May 29, 2024 14:42
@AlexFenlon AlexFenlon merged commit 04bd4e9 into main Jun 4, 2024
78 checks passed
@AlexFenlon AlexFenlon deleted the feat/telemetry-granular-service-count branch June 4, 2024 07:50
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@AlexFenlon @ssrahul96
Add Granular Services Counts to Telemetry (nginxinc#5627)
f064423
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@j1m-ryan j1m-ryan j1m-ryan left review comments

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Granularise Service Counts
6 participants
@AlexFenlon @ADubhlaoich @j1m-ryan @vepatel @jjngx @shaun-nx